Skip to content

Rework the handling of annotations for scope and collection. #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mikereiche
Copy link
Collaborator

The scope and collection repository annotations were not being
passed on to derived and @query remove operations.

The handling of scope and collection annotations has been reworked in:

  1. CrudMethodMetadataProcessor
  2. All the *OperationSuppport constructors - the initial scope and collection is
    taken from the domainEntity class.
  3. PseudoArgs
  4. AbstractCouchbaseQuery/AbstractReactiveCouchbaseQuery add the scope/collection
    to the remove operation (analogous to the find Operation).
  5. Scope/Collection is passed as args to the execute() method - even though this
    is redundant at the moment.

Closes #1441.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

The scope and collection repository annotations were not being
passed on to derived and @query remove operations.

The handling of scope and collection annotations has been reworked in:

1) CrudMethodMetadataProcessor
2) All the *OperationSuppport constructors - the initial scope and collection is
taken from the domainEntity class.
3) PseudoArgs
4) AbstractCouchbaseQuery/AbstractReactiveCouchbaseQuery add the scope/collection
to the remove operation (analogous to the find Operation).
5) Scope/Collection is passed as args to the execute() method - even though this
is redundant at the moment.

Closes #1441.
@mikereiche mikereiche merged commit 30a0b88 into main Jun 17, 2022
@mikereiche mikereiche deleted the datacouch_1441_2_consider_scope_and_collection_from_repository_annotation branch June 21, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scope and collection annotations on repository are not considered during execution.
1 participant